Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a little thumbnail next to the title, using the image from the metatags #262

Merged
merged 3 commits into from
Apr 17, 2021

Conversation

jeop10
Copy link
Contributor

@jeop10 jeop10 commented Apr 17, 2021

Related to Generate screenshots for links #18

jeop10 added 2 commits April 16, 2021 19:48
First step into implementing a "screenshot" of the added links, so this commits makes possible to retrieve the images that exists on the metatags and store it as the thumbnail.
Related to Generate screenshots for links Kovah#18
@Kovah
Copy link
Owner

Kovah commented Apr 17, 2021

Looks great! 👍
Test fail because the thumbnail field is missing from the fallback. After you add it, I will merge the pull request.
app/Helper/HtmlMeta.php#93

self::$fallback = [
    'success' => false,
    'title' => parse_url($url, PHP_URL_HOST) ?? $url,
    'description' => false,
    'thumbnail' => null,
];

@jeop10
Copy link
Contributor Author

jeop10 commented Apr 17, 2021

You are right, sorry that I missed this. It should be fixed now 😄

@Kovah
Copy link
Owner

Kovah commented Apr 17, 2021

Perfect. Thank you very much for the idea and pull request! 🥳

@Kovah Kovah merged commit 228b38a into Kovah:dev Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants