Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate screenshots for links #18

Open
Kovah opened this issue Jan 18, 2019 · 8 comments
Open

Generate screenshots for links #18

Kovah opened this issue Jan 18, 2019 · 8 comments
Labels
Enhancement Any requests for improvements or new features Help wanted Help is appreciated for this issue.

Comments

@Kovah
Copy link
Owner

Kovah commented Jan 18, 2019

Implement a method or web service to generate screenshots for links to display the content of a site as a small preview.

Update as of Apr. 2021:
A "light" version of this feature was implemented by @jeop10. LinkAce saves a thumbnail URL to the database if the websites provides a og:image or twitter:image. I will keep this issue open for a possible full implementation in the future.
Support for thumbnails were released in v1.6.0.

@Kovah Kovah added the Enhancement Any requests for improvements or new features label Jan 18, 2019
@Kovah Kovah added this to the v1.0.0 milestone Jan 20, 2019
@Kovah Kovah removed this from the v1.0.0 milestone Sep 12, 2019
@Kovah
Copy link
Owner Author

Kovah commented Jan 27, 2020

Could be interesting: https://github.com/KnpLabs/snappy

@Kovah Kovah added this to the v2.0.0 milestone Feb 9, 2020
@Kovah Kovah removed this from the v2.0.0 milestone Nov 11, 2020
@jeop10
Copy link
Contributor

jeop10 commented Apr 15, 2021

Hello first of all, I just discovered LinkAce and I think It's amazing.

Regarding this issue, do you think it will be good (as a first step) just to gather the image that comes from the metatags twitter:image or og:image?

I have been debating on create such modification in my local copy just to see how it works.

Let me know if this is something acceptable for a PR.

Best regards

@Kovah
Copy link
Owner Author

Kovah commented Apr 15, 2021

That is a great idea! We get all HTML meta while adding the link anyway, so LinkAce can save the og:image or twitter:image url to the database. The url can be used to display the picture in the application.
Woul be happy to accept a PR for that.

@jeop10
Copy link
Contributor

jeop10 commented Apr 15, 2021

What do you think of this, I am not sure at all about the size of the thumbnail I tried copying the size of others projects but I don't know if you think its too big.

List:
list

Detail:
detail

Another idea that I have is just to have a setting that allow the user to select on which side they want the image (left or right)

Best regards.

@Kovah
Copy link
Owner Author

Kovah commented Apr 15, 2021

Awesome!
I would leave it like that for now, looks fine for me. Advanced settings might be added later on.

@jeop10
Copy link
Contributor

jeop10 commented Apr 16, 2021

Quick update on this:

I completely forgot to check how this look on tablet and mobile width, and there is some adjustment that I need to make to make it work. I cant guarantee that I would have done by today, but I will try to make the pull request tomorrow.

Best Regards.

jeop10 added a commit to jeop10/LinkAce that referenced this issue Apr 16, 2021
First step into implementing a "screenshot" of the added links, so this commits makes possible to retrieve the images that exists on the metatags and store it as the thumbnail.
jeop10 added a commit to jeop10/LinkAce that referenced this issue Apr 17, 2021
Related to Generate screenshots for links Kovah#18
jeop10 added a commit to jeop10/LinkAce that referenced this issue Apr 17, 2021
Kovah added a commit that referenced this issue Apr 18, 2021
@iwconfig
Copy link

iwconfig commented Dec 4, 2021

Have you checked out https://www.thum.io/? You get 1000 screenshot hits per month for free and you could provide a way for users to add their own api key.

Here's an example screenshot: https://image.thum.io/get/maxAge/12/width/2000/https://github.com/Kovah/LinkAce/issues/18

I don't know what the maximum width/height available but it's more than good enough. Full page view is a paid feature though but I don't think it's needed.

Here's the documentation: https://www.thum.io/documentation/api/url.

You could also have a toggle button for showing a preview of the site, albeit somewhat unintuitive.

  1. It would save some of those free requests
  2. It would prevent sensitive, personal or whatever you don't want to be sent to thum.io, in regards to privacy

This would mitigate issue #301

@cweiske
Copy link

cweiske commented Sep 14, 2023

I once built a self-hosted tool that provides an API to obtain website screenshots: https://cweiske.de/phancap.htm and https://github.com/cweiske/phancap
It's not usable anymore because of PHP major version changes, but maybe it's a start for someone.

@Kovah Kovah moved this to Ideas & Requests in LinkAce Roadmap Aug 14, 2024
@Kovah Kovah added the Help wanted Help is appreciated for this issue. label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Any requests for improvements or new features Help wanted Help is appreciated for this issue.
Projects
Status: Ideas & Requests
Development

No branches or pull requests

4 participants