-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate screenshots for links #18
Comments
Could be interesting: https://github.com/KnpLabs/snappy |
Hello first of all, I just discovered LinkAce and I think It's amazing. Regarding this issue, do you think it will be good (as a first step) just to gather the image that comes from the metatags I have been debating on create such modification in my local copy just to see how it works. Let me know if this is something acceptable for a PR. Best regards |
That is a great idea! We get all HTML meta while adding the link anyway, so LinkAce can save the og:image or twitter:image url to the database. The url can be used to display the picture in the application. |
What do you think of this, I am not sure at all about the size of the thumbnail I tried copying the size of others projects but I don't know if you think its too big. Another idea that I have is just to have a setting that allow the user to select on which side they want the image (left or right) Best regards. |
Awesome! |
Quick update on this: I completely forgot to check how this look on tablet and mobile width, and there is some adjustment that I need to make to make it work. I cant guarantee that I would have done by today, but I will try to make the pull request tomorrow. Best Regards. |
First step into implementing a "screenshot" of the added links, so this commits makes possible to retrieve the images that exists on the metatags and store it as the thumbnail.
Related to Generate screenshots for links Kovah#18
Related to Generate screenshots for links Kovah#18
Have you checked out https://www.thum.io/? You get 1000 screenshot hits per month for free and you could provide a way for users to add their own api key. Here's an example screenshot: https://image.thum.io/get/maxAge/12/width/2000/https://github.com/Kovah/LinkAce/issues/18 I don't know what the maximum width/height available but it's more than good enough. Full page view is a paid feature though but I don't think it's needed. Here's the documentation: https://www.thum.io/documentation/api/url. You could also have a toggle button for showing a preview of the site, albeit somewhat unintuitive.
This would mitigate issue #301 |
I once built a self-hosted tool that provides an API to obtain website screenshots: https://cweiske.de/phancap.htm and https://github.com/cweiske/phancap |
Implement a method or web service to generate screenshots for links to display the content of a site as a small preview.
Update as of Apr. 2021:
A "light" version of this feature was implemented by @jeop10. LinkAce saves a thumbnail URL to the database if the websites provides a og:image or twitter:image. I will keep this issue open for a possible full implementation in the future.
Support for thumbnails were released in v1.6.0.
The text was updated successfully, but these errors were encountered: