Replace usage js with WasmJs in README.md #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnikolova
reviewed
Feb 6, 2024
README.md
Outdated
|
|
||
| # Get started | ||
|
|
||
| See [Getting started](https://github.com/kotlin/kotlinx.html/wiki/Getting-started) page for details how to include the library. | ||
|
|
||
| # DOM | ||
| You can build DOM tree with JVM and JS naturally | ||
| You can build a DOM tree with JVM, JS, and WASM naturally |
There was a problem hiding this comment.
I guess it should be like easy
README.md
Outdated
|
|
||
| See example for JavaScript-targeted Kotlin | ||
| See example for WasmJs-targeted Kotlin: |
There was a problem hiding this comment.
Rephrase: "The following example shows how to build the DOM for WasmJs-targeted Kotlin:"
README.md
Outdated
| @@ -6,34 +6,51 @@ | |||
|
|
|||
| # kotlinx.html | |||
|
|
|||
| A kotlinx.html library provides DSL to build HTML to [Writer](https://docs.oracle.com/javase/8/docs/api/java/io/Writer.html)/[Appendable](https://docs.oracle.com/javase/8/docs/api/java/lang/Appendable.html) or DOM. Available to all Kotlin Multiplatform targets and browser(or other JavaScript engine) for better [Kotlin programming](https://kotlinlang.org) for Web. | |||
| A kotlinx.html library provides a DSL to build HTML to [Writer](https://docs.oracle.com/javase/8/docs/api/java/io/Writer.html)/[Appendable](https://docs.oracle.com/javase/8/docs/api/java/lang/Appendable.html) or DOM. Available to all Kotlin Multiplatform targets and browser(or other JavaScript engine) for better [Kotlin programming](https://kotlinlang.org) for Web. | |||
There was a problem hiding this comment.
Here it would be "The kotlinx.html library...".
Also browsers and engines in plural.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #256