Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnknownServiceException #333

Closed
wants to merge 1 commit into from

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented May 30, 2024

I noticed Kotr is migrating to kotlinx-io in ktorio/ktor#4032, and I sent a PR ktorio/ktor#3725 which is depending on UnknownServiceException, it would be awesome to port this exception for all platforms to get rid of custom implementations in Ktor.

Port Java's UnknownServiceException for all platforms.
@fzhinkin
Copy link
Collaborator

Hey @Goooler!

Thanks for opening the PR. Unfortunately, I don't think that this exception is a good fit for the kotlinx-io right now for a few reasons:

  • currently, kotlinx-io provides no networking-related functionality;
  • having only UnknownServiceException and not having other exceptions covering various networking and URN/URL-related problems feels a bit off.

So for now, I'd suggest leaving the exception in the Ktor codebase.

However, in the long run, it would make sense to supply a separate package stuffed with networking-related exceptions to serve as a common types for the ecosystem.

@Goooler
Copy link
Contributor Author

Goooler commented May 30, 2024

Makes sense!

@Goooler Goooler closed this May 30, 2024
@Goooler Goooler deleted the add-unknown-host-exception branch May 30, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants