Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain selections when editor blurred, and fix file uploads on race conditions #227

Merged
merged 16 commits into from
Nov 22, 2024

Conversation

KonnorRogers
Copy link
Owner

@KonnorRogers KonnorRogers commented Nov 22, 2024

  • - Maintain link selection even while the editor is not focused.
  • - Fixes File uploading indicator fills before uploading is complete #226 This is quite interesting, because we freeze progress at 90%, and then never allow the progress indicator to finish until the re-fetch succeeds. The only possible issue I could foresee is if somehow a page has permission to upload a resource, but not permission to view it? Maybe its just better to wait a couple ticks after upload??
  • - Add a pendingAttachmentUploads field

Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: 8e32f2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
rhino-editor Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rhino-editor ✅ Ready (Inspect) Visit Preview Nov 22, 2024 7:50am

@KonnorRogers KonnorRogers changed the title Konnorrogers/maintain link selection Maintain selections when editor blurred, and fix file uploads on race conditions Nov 22, 2024
@KonnorRogers KonnorRogers merged commit 924d0ff into main Nov 22, 2024
3 checks passed
@KonnorRogers KonnorRogers deleted the konnorrogers/maintain-link-selection branch November 22, 2024 08:00
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File uploading indicator fills before uploading is complete
1 participant