chore: do not run goroutines in manager.New #7121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
chore/no-goroutines-in-mgr-constructor
branch
from
e66c75c to
d11287f
Compare
czeslavo
force-pushed
the
chore/no-goroutines-in-mgr-constructor
branch
2 times, most recently
from
16d1b58 to
0cf8bfc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/kic-as-library #7121 +/- ##
=====================================================
Coverage ? 77.0%
=====================================================
Files ? 220
Lines ? 25221
Branches ? 0
=====================================================
Hits ? 19443
Misses ? 4780
Partials ? 998 ☔ View full report in Codecov by Sentry. |
czeslavo
force-pushed
the
chore/no-goroutines-in-mgr-constructor
branch
from
0cf8bfc to
2c7fb9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove spawning of long-running goroutines from the
internalmanager.Newconstructor.Which issue this PR fixes:
Closes #7099.