Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to release/3.4.x] fix(manager): Run AddToScheme only once in scheme.Get #7116

Open
wants to merge 1 commit into
base: release/3.4.x
Choose a base branch
from

Conversation

randmonkey
Copy link
Contributor

Backport of #7105.

* run AddToScheme only when not done

* initialize scheme in var def

(cherry picked from commit ea72f4a)
@randmonkey randmonkey requested a review from a team as a code owner February 13, 2025 03:40
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release/3.4.x@0c9c290). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/store/cache_stores.go 0.0% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release/3.4.x   #7116   +/-   ##
===============================================
  Coverage                 ?   76.6%           
===============================================
  Files                    ?     211           
  Lines                    ?   25215           
  Branches                 ?       0           
===============================================
  Hits                     ?   19325           
  Misses                   ?    4886           
  Partials                 ?    1004           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant