fix: GatewayReconciler will fall into a loop and cannot converge to stable state #7111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
GatewayReconciler will determine the change of ListenerStatus to decide whether to update Gateway.status. When Gateway.spec.listeners has many entries (greater than 10 and has a certain relationship with the number of HTTPRoutes), GatewayReconciler will fall into a loop and cannot converge to a stable state (updating status will trigger a new gateway reconciler event, and the new round of reconcile will always find differences). The reason here is that when using reflect.DeepEqual to compare two slice structs, the order of elements will affect the result, and Gateway.status.listeners[].conditions[].lastTransitionTime will always be assigned the current time in each round of reconcile, which should be excluded.
Which issue this PR fixes:
fixes #7031
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR