Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Makefile): fix target debug.skaffold #6652

Merged
merged 1 commit into from
Nov 8, 2024
Merged

chore(Makefile): fix target debug.skaffold #6652

merged 1 commit into from
Nov 8, 2024
+0 −1

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Nov 8, 2024 •
edited
Loading

What this PR does / why we need it:

Running

make debug.skaffold

leads to

...
Checking cache...
 - kic-placeholder: Found Locally
WARN[0001] Failed to render :running [kubectl --context kind-kong-test kustomize /Users/[email protected]/Documents/work/kubernetes-ingress-controller/config/variants/multi-gw/debug]
 - stdout: ""
 - stderr: "# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.\nerror: accumulating resources: accumulation err='accumulating resources from '../../../crd/incubator': '/Users/[email protected]/Documents/work/kubernetes-ingress-controller/config/crd/incubator' must resolve to a file': recursed merging from path '/Users/[email protected]/Documents/work/kubernetes-ingress-controller/config/crd/incubator': may not add resource with an already registered id: CustomResourceDefinition.v1.apiextensions.k8s.io/kongservicefacades.incubator.ingress-controller.konghq.com.[noNs]\n"
 - cause: exit status 1, please fix the error and press any key to continue.  subtask=-1 task=DevLoop

this PR fixes it. It seems that removing it was omitted by mistake previously

@programmer04 programmer04 added the area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. label Nov 8, 2024
@programmer04 programmer04 self-assigned this Nov 8, 2024
@programmer04 programmer04 requested a review from a team as a code owner November 8, 2024 16:38
@programmer04 programmer04 enabled auto-merge (squash) November 8, 2024 16:38
pmalek
pmalek approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm it fixes it for me as well. 🎖️

@programmer04 programmer04 merged commit ef06991 into main Nov 8, 2024
62 checks passed
@programmer04 programmer04 deleted the fix-target branch November 8, 2024 16:57
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.9%. Comparing base (030db71) to head (071e70c).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #6652     +/-   ##
=======================================
+ Coverage   72.2%   78.9%   +6.7%     
=======================================
  Files        202     201      -1     
  Lines      25817   23761   -2056     
=======================================
+ Hits       18643   18751    +108     
+ Misses      6159    4036   -2123     
+ Partials    1015     974     -41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmalek pmalek pmalek approved these changes

Assignees

@programmer04 programmer04

Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@programmer04 @pmalek