Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

konnect: use sdk-konnect-go for roles #6648

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Nov 8, 2024

What this PR does / why we need it:

Use sdk-konnect-go for roles

Which issue this PR fixes:

Part of #6548

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pmalek pmalek added the area/konnect Issues and PRs related to Konnect label Nov 8, 2024
@pmalek pmalek added this to the KIC v3.4.x milestone Nov 8, 2024
@pmalek pmalek self-assigned this Nov 8, 2024
@pmalek pmalek force-pushed the konnect-sdk-client-roles branch 3 times, most recently from 5f1ac10 to 35e201b Compare November 8, 2024 15:53
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.8%. Comparing base (565eb08) to head (0a2ed96).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6648     +/-   ##
=======================================
+ Coverage   77.6%   77.8%   +0.1%     
=======================================
  Files        201     200      -1     
  Lines      23766   23657    -109     
=======================================
- Hits       18456   18406     -50     
+ Misses      4359    4319     -40     
+ Partials     951     932     -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek force-pushed the konnect-sdk-client-roles branch 2 times, most recently from 7e7de61 to 94fee7d Compare November 12, 2024 12:02
@pmalek pmalek marked this pull request as ready for review November 12, 2024 13:01
@pmalek pmalek requested a review from a team as a code owner November 12, 2024 13:01
@pmalek pmalek enabled auto-merge (squash) November 12, 2024 13:01
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️

@pmalek pmalek merged commit a14ea42 into main Nov 12, 2024
43 checks passed
@pmalek pmalek deleted the konnect-sdk-client-roles branch November 12, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/konnect Issues and PRs related to Konnect size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants