-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(diagnostics) add diff endpoints #6131
Open
rainest
wants to merge
13
commits into
main
Choose a base branch
from
feat/diff-db
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Aug 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a01e082 - Browse repository at this point
Copy the full SHA a01e082View commit details -
chore: rename ConfigDump to ClientDiagnostic
Rename the diagnostics.ConfigDump struct to ClientDiagnostic to reflect that it now handles multiple types of diagnostic data (config dumps, config diffs, and fallback status) from the Kong client.
Configuration menu - View commit details
-
Copy full SHA for 03725c8 - Browse repository at this point
Copy the full SHA 03725c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8c1b9f - Browse repository at this point
Copy the full SHA a8c1b9fView commit details -
feat: add diff collector and send to it
Add a struct to hold diff history in the diagnostic server. It holds a fixed number of diffs (5, arbitrarily) and provides functions to update and view history by config hash. Add a diagnostics function to generate diagnostic diff structs from GDR event data. Add a diagnostics update loop case to handle inbound diffs. Call the diagnostic diff generator when processing an event and append the diagnostic diff to the diff list to the DB mode event handler.
Configuration menu - View commit details
-
Copy full SHA for 6e21b76 - Browse repository at this point
Copy the full SHA 6e21b76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 948eaa8 - Browse repository at this point
Copy the full SHA 948eaa8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0230c3f - Browse repository at this point
Copy the full SHA 0230c3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44cab87 - Browse repository at this point
Copy the full SHA 44cab87View commit details -
chore: dump sensitive config during integration
Dump sensitive config during integration, mostly to support debugging the diff endpoint. While there's no diff diagnostic integration test, having it available allows for easier interactive debugging of the endpoint, or viewing diff states when running DB-backed tests.
Configuration menu - View commit details
-
Copy full SHA for 7447130 - Browse repository at this point
Copy the full SHA 7447130View commit details -
Add timestamps and a list of available diffs to the diff endpoint. Add unit tests for the diff endpoint.
Configuration menu - View commit details
-
Copy full SHA for 1ae9e30 - Browse repository at this point
Copy the full SHA 1ae9e30View commit details -
chore: clean up comments and lints
Remove scaffolding comments and unfinished wishlist items. Add missing doc comments. Clean up some garbage the linter caught.
Configuration menu - View commit details
-
Copy full SHA for 342ce1a - Browse repository at this point
Copy the full SHA 342ce1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a57d877 - Browse repository at this point
Copy the full SHA a57d877View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77069ae - Browse repository at this point
Copy the full SHA 77069aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29c5926 - Browse repository at this point
Copy the full SHA 29c5926View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.