feat: support multiple backendRefs for HTTPRoute load-balancing #2402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneutt
added
area/feature
rainest
suggested changes
Apr 7, 2022
There was a problem hiding this comment.
I don't know how we solve the problem of allowing edits to Services' annotations after they've been used in a multi-backend route effectively outside an intentional stop the world or something stupid like designating a primary Service used as the sole source of truth. It's quite annoying to deal with.
shaneutt
force-pushed
the
shaneutt/multiple-backendrefs
branch
from
b1ca024
to
4c09144
Compare
shaneutt
force-pushed
the
shaneutt/multiple-backendrefs
branch
from
b0f1fff
to
5572595
Compare
shaneutt
force-pushed
the
shaneutt/multiple-backendrefs
branch
from
25e9a14
to
fea3203
Compare
rainest
approved these changes
Apr 11, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds support for multiple
backendRefsinHTTPRouteobjects, enabling weighted load-balancing between multiple services for any specific routing rule.Which issue this PR fixes
Resolves #2166
Notes:
Also running E2E tests for this: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/2110253994 ✔️
PR Readiness Checklist:
CHANGELOG.mdrelease notes have been updated