Skip to content

Commit

Permalink
skip setting http/2 of admin API if skipPatches disabled
Browse files Browse the repository at this point in the history
  • Loading branch information
randmonkey committed Nov 27, 2023
1 parent 9273147 commit 52c28f1
Showing 1 changed file with 11 additions and 8 deletions.
19 changes: 11 additions & 8 deletions test/e2e/helpers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -280,14 +280,17 @@ func (d ManifestDeploy) Run(ctx context.Context, t *testing.T, env environments.
t.Log("waiting for controller to be ready")
deployments := getManifestDeployments(d.Path)

adminAPINoHTTP2Range := kong.MustNewRange("<" + adminAPIHTTP2MinimalKongVersion.String())
kongVersion, err := getKongVersionFromOverrideImageTag()
if err == nil && adminAPINoHTTP2Range(kongVersion) {
t.Logf(
"Kong version %s is below %s, should disable HTTP/2 on admin API",
kongVersion.String(), adminAPIHTTP2MinimalKongVersion.String(),
)
removeAdminListenHTTP2(ctx, t, env, deployments.ProxyNN)
if !d.SkipTestPatches {
adminAPINoHTTP2Range := kong.MustNewRange("<" + adminAPIHTTP2MinimalKongVersion.String())
kongVersion, err := getKongVersionFromOverrideImageTag()
if err == nil && adminAPINoHTTP2Range(kongVersion) {
t.Logf(
"Kong version %s is below %s, should disable HTTP/2 on admin API",
kongVersion.String(), adminAPIHTTP2MinimalKongVersion.String(),
)
removeAdminListenHTTP2(ctx, t, env, deployments.ProxyNN)
}

}

waitForDeploymentRollout(ctx, t, env, deployments.ControllerNN.Namespace, deployments.ControllerNN.Name)
Expand Down

1 comment on commit 52c28f1

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Go Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: 52c28f1 Previous: deb5427 Ratio
BenchmarkDeckgenGenerateSHA - ns/op 74875 ns/op 29243 ns/op 2.56
BenchmarkDefaultContentToDBLessConfigConverter_Convert - ns/op 111.9 ns/op 70.91 ns/op 1.58

This comment was automatically generated by workflow using github-action-benchmark.

CC: @Kong/k8s-maintainers

Please sign in to comment.