Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin): reject AdminAPI call with empty tags #13723

Merged
merged 3 commits into from
Oct 30, 2024
Merged

fix(admin): reject AdminAPI call with empty tags #13723

merged 3 commits into from
Oct 30, 2024

Commits on Oct 30, 2024

  1. fix(admin): reject AdminAPI call with empty tags 

    When querying entities that have tags assigned a user can send
a request with `tags` parameter. Previously sending `tags=''`
(empty string or explicit nil) resulted in 500 error.
This commit changes that so that it returns 400 error as empty
explicit tags are not allowed

KAG-5496
Fix #13591
    @nowNick
    nowNick committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    aef1c7a View commit details
    Browse the repository at this point in the history

  2. fixup! fix(admin): reject AdminAPI call with empty tags 

    PR Review fixes - remove typo emtpy -> empty
    @nowNick
    nowNick committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    d3cac86 View commit details
    Browse the repository at this point in the history

  3. fixup! fix(admin): reject AdminAPI call with empty tags 

    PR Review fixes - improve error message: remove info about empty string
    @nowNick
    nowNick committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3b5af35 View commit details
    Browse the repository at this point in the history