Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support paths filtering #102 #103

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

ludovic-pourrat
Copy link
Contributor

Feature proposal

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1846620509

  • -4 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 32.665%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/Workspace.ts 0 2 0.0%
src/core/WorkspaceConfig.ts 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/core/Workspace.ts 1 20.55%
Totals Coverage Status
Change from base Build 1611580574: -0.8%
Covered Lines: 103
Relevant Lines: 268

💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 15, 2022

Pull Request Test Coverage Report for Build 5357855444

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 31.818%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/Workspace.ts 0 2 0.0%
src/core/WorkspaceConfig.ts 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/core/Workspace.ts 1 17.98%
Totals Coverage Status
Change from base Build 4567205632: -0.7%
Covered Lines: 113
Relevant Lines: 296

💛 - Coveralls

@zekth zekth requested a review from HenriPro February 22, 2022 08:11
@ludovic-pourrat
Copy link
Contributor Author

Hi,

Any comments / feedback on this one ?

Many thanks.

Copy link
Contributor

@HenriPro HenriPro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, other than I think we have to keep the file size limit, can approve after that.

@ludovic-pourrat
Copy link
Contributor Author

Ok I will revert it back to 10mb and further investigate on our side why we are getting errors related to this.

I will raise another issue / PR in case.

@ludovic-pourrat
Copy link
Contributor Author

@HenriPro could you review again please ?

Many thanks.

@ludovic-pourrat
Copy link
Contributor Author

Hi, could you provide a review ?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants