fix(sdk): get response size from bytesRead value

packages/insomnia-sdk/src/objects/__tests__/request.test.ts

@@ -1,7 +1,7 @@
 import { describe, expect, it } from 'vitest';
 
 import { Header, HeaderList } from '../headers';
-import { calculateRequestSize, mergeRequestBody, Request, RequestBody, RequestBodyOptions, toScriptRequestBody } from '../request';
+import { calculatePayloadSize, mergeRequestBody, Request, RequestBody, RequestBodyOptions, toScriptRequestBody } from '../request';
 
 describe('test request and response objects', () => {
     it('test RequestBody methods', () => {
@@ -145,8 +145,8 @@ describe('test request and response objects', () => {
     ];
 
     reqBodyTestCases.forEach(({ body, headers, expectedTotal }) => {
-        it(`test calculateRequestSize: ${body.raw}`, () => {
-            const reqSize = calculateRequestSize(new RequestBody(body), headers);
+        it(`test calculatePayloadSize: ${body.raw}`, () => {
+            const reqSize = calculatePayloadSize(new RequestBody(body).toString(), headers);
 
             expect(reqSize.total).toEqual(expectedTotal);
         });

packages/insomnia-sdk/src/objects/request.ts

@@ -388,7 +388,7 @@ export class Request extends Property {
     }
 
     size(): RequestSize {
-        return calculateRequestSize(this.body, this.headers);
+        return calculatePayloadSize((this.body || '').toString(), this.headers);
     }
 
     override toJSON() {
@@ -684,8 +684,18 @@ export function mergeRequests(
     };
 }
 
-export function calculateRequestSize(body: RequestBody | undefined, headers: HeaderList<Header>): RequestSize {
-    const bodySize = new Blob([(body || '').toString()]).size;
+export function calculatePayloadSize(body: string, headers: HeaderList<Header>): RequestSize {
+    const bodySize = new Blob([body]).size;
+    const headerSize = calculateHeadersSize(headers);
+    return {
+        body: bodySize,
+        header: headerSize,
+        total: bodySize + headerSize,
+        source: 'COMPUTED',
+    };
+}
+
+export function calculateHeadersSize(headers: HeaderList<Header>): number {
     const headerSize = new Blob([
         headers.reduce(
             (acc, header) => (acc + header.toString() + '\n'),
@@ -694,10 +704,5 @@ export function calculateRequestSize(body: RequestBody | undefined, headers: Hea
         ),
     ]).size;
 
-    return {
-        body: bodySize,
-        header: headerSize,
-        total: bodySize + headerSize,
-        source: 'COMPUTED',
-    };
+    return headerSize;
 }

packages/insomnia-sdk/src/objects/response.ts

@@ -8,7 +8,7 @@ import { Cookie, type CookieOptions } from './cookies';
 import { CookieList } from './cookies';
 import { Header, type HeaderDefinition, HeaderList } from './headers';
 import { Property, unsupportedError } from './properties';
-import { Request } from './request';
+import { calculateHeadersSize, Request } from './request';
 
 export interface ResponseOptions {
     code: number;
@@ -20,6 +20,7 @@ export interface ResponseOptions {
     stream?: Buffer | ArrayBuffer;
     responseTime: number;
     originalRequest: Request;
+    bytesRead?: number; // this is from Insomnia for returning response size() directly
 }
 
 export interface ResponseContentInfo {
@@ -44,6 +45,8 @@ export class Response extends Property {
     status: string;
     stream?: Buffer | ArrayBuffer;
 
+    private bytesRead: number; //
+
     constructor(options: ResponseOptions) {
         super();
 
@@ -67,6 +70,8 @@ export class Response extends Property {
         } else {
             this.status = detectedStatus;
         }
+
+        this.bytesRead = options.bytesRead || 0;
     }
 
     // TODO: the accurate type of the response should be given
@@ -180,14 +185,14 @@ export class Response extends Property {
         return this.status;
     }
 
-    size(): number {
-        try {
-            const contentLength = this.headers.get('Content-Length');
-            // TODO: improve this by manual counting
-            return contentLength == null ? -1 : parseInt(contentLength.valueOf());
-        } catch (e) {
-            throw Error('size: ${e}');
-        }
+    size() {
+        const headerSize = calculateHeadersSize(this.headers);
+        return {
+            body: this.bytesRead,
+            header: headerSize,
+            total: this.bytesRead + headerSize,
+            source: 'COMPUTED',
+        };
     }
 
     text() {
@@ -305,6 +310,7 @@ export function toScriptResponse(
         // stream is duplicated with body
         responseTime: partialResponse.elapsedTime,
         originalRequest,
+        bytesRead: partialResponse.bytesRead,
     };
 
     return new Response(responseOption);

packages/insomnia/src/network/network.ts

@@ -615,6 +615,7 @@ export interface sendCurlAndWriteTimelineResponse extends ResponsePatch {
   statusMessage: string;
   cookies: Cookie[];
   timeline: string[];
+  bytesRead?: number;
 }
 
 export async function sendCurlAndWriteTimeline(