fix: correctly handle route schema defaults with Konnect #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kong Gateway supports different schemas for different router versions. On the other hand, Konnect can support only one schema including all fields from 'traditional' and 'expressions' router schemas. This may be problematic when it comes to defaults injection, because the defaults for the 'traditiona' router schema can be wrongly injected into the 'expressions' route configuration. Here we make sure that only the fields that are supported for a given router version are set in the route configuration.
czeslavo
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Thanks for that @GGabriele! 🎖️ I verified it works as expected in KIC.
1 task
pmalek
reviewed
Feb 7, 2024
| // On the other hand, Konnect can support only one schema including all | ||
| // fields from 'traditional' and 'expressions' router schemas. | ||
| // This may be problematic when it comes to defaults injection, because | ||
| // the defaults for the 'traditiona' router schema can be wrongly injected |
pmalek
reviewed
Feb 7, 2024
Comment on lines
+2838
to
+2840
| d, _ := utils.GetDefaulter(ctx, defaulterTestOpts) | ||
| b.defaulter = d | ||
| b.intermediate, _ = state.NewKongState() |
There was a problem hiding this comment.
Too late to the party but any particular reason not to check the errors here?
There was a problem hiding this comment.
could be done, but not meaningful for the specific test...copy&pasta mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kong Gateway supports different schemas for different router versions. On the other hand, Konnect can support only one schema including all fields from 'traditional' and 'expressions' router schemas. This may be problematic when it comes to defaults injection, because the defaults for the 'traditiona' router schema can be wrongly injected into the 'expressions' route configuration.
Here we make sure that only the fields that are supported for a given router version are set in the route configuration.
Summary
SUMMARY_GOES_HERE
Full changelog
Issues resolved
Fix #XXX
Documentation
Testing