fix(diff): support auto fields #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samugi
force-pushed
the
fix/support-auto-fields-diff
branch
from
582099a
to
b1914e8
Compare
samugi
force-pushed
the
fix/support-auto-fields-diff
branch
5 times, most recently
from
7d06537
to
1d145a3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
call the new utils function FillPluginsDefaultsAutoFields from go-kong to ensure auto fields are considered when doing the diff
fixes a bug that was introduced in e72f4c2 where noops were still detected as updates. That happened because of a check happening in plugin.go that detected the crud operation based on a diff. When done without considering default/auto fields, this check would see differences where there were none. This resulted in unnecessary updates to the DB and wrong diff strings during `sync` and `diff`. This commit adds defaults/auto fields to the configuration used for that diff.
samugi
force-pushed
the
fix/support-auto-fields-diff
branch
from
1d145a3
to
ad71783
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
- Coverage 29.99% 29.97% -0.03%
==========================================
Files 106 106
Lines 12571 12581 +10
==========================================
Hits 3771 3771
- Misses 8340 8350 +10
Partials 460 460 ☔ View full report in Codecov by Sentry. |
randmonkey
reviewed
Sep 3, 2024
randmonkey
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(diff): support auto fields
fix(crud): detect operation correctly
Full changelog
Issues resolved
KAG-5210
Documentation
Testing