fix: set default strip_path to true #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGabriele
force-pushed
the
fix/strip_path-false
branch
from
555bcb3
to
c171b0f
Compare
In the past decK had to set the default value of the `strip_path` field to [false](https://github.com/Kong/deck/blob/v1.26.0/utils/constants.go#L22) because of some limitation in the library used for defaults injection: this was a workaround to allow this field to be set to `false`. Then, if the field was not set in the configuration, the field was then turned into `true` at runtime via inspection of the Kong Admin API. This commit changes the decK default for the `strip_path` field to `true`, since now the underlying library has fixed the issue that triggered this workaround in the first place.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
=======================================
Coverage 33.70% 33.70%
=======================================
Files 101 101
Lines 12323 12323
=======================================
Hits 4154 4154
Misses 7760 7760
Partials 409 409 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past decK had to set the default value of the
strip_pathfield to false because of some limitation in the library used for defaults injection: this was a workaround to allow this field to be set tofalse. Then, if the field was not set in the configuration, the field was then turned intotrueat runtime via inspection of the Kong Admin API.This commit changes the decK default for the
strip_pathfield totrue, since now the underlying library has fixed the issue that triggered this workaround in the first place.