Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: use testing helpers for env and cleanup #992

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Aug 2, 2023

No description provided.

@pmalek pmalek added the testing label Aug 2, 2023
@pmalek pmalek self-assigned this Aug 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (af7eaa2) 33.59% compared to head (f7ff57d) 33.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #992   +/-   ##
=======================================
  Coverage   33.59%   33.59%           
=======================================
  Files         101      101           
  Lines       12364    12364           
=======================================
  Hits         4154     4154           
  Misses       7801     7801           
  Partials      409      409           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek marked this pull request as ready for review August 2, 2023 11:17
@pmalek pmalek requested a review from a team August 2, 2023 11:17
GGabriele
GGabriele previously approved these changes Aug 2, 2023
@pmalek pmalek force-pushed the use-testing-helpers-for-envs-and-cleanup branch from 9faaded to f7ff57d Compare August 4, 2023 14:27
@pmalek pmalek requested a review from GGabriele August 4, 2023 14:34
@pmalek pmalek enabled auto-merge (squash) August 4, 2023 14:34
Copy link
Collaborator

@GGabriele GGabriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pmalek pmalek merged commit c823413 into main Aug 4, 2023
34 checks passed
@pmalek pmalek deleted the use-testing-helpers-for-envs-and-cleanup branch August 4, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants