fix: konnect cli flags getting considered for online validation. #1424
+45
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier, if konnect control plane information was passed via cli flags, online validation for Konnect was failing. This change fixes the issue.
Prashansa-K
requested review from
samugi and
GGabriele
and removed request for
GGabriele
samugi
approved these changes
Oct 22, 2024
| var errs []error | ||
|
|
||
| if targetContent.Workspace != "" { | ||
| errs = append(errs, errors.New(errWorkspace)) | ||
| } | ||
|
|
||
| if targetContent.Konnect == nil { | ||
| if targetContent.Konnect == nil && dumpConfig.KonnectControlPlane == "" { |
There was a problem hiding this comment.
is it always going to be "" or could it also be nil?
There was a problem hiding this comment.
It's a string value. So, always "".
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1424 +/- ##
=======================================
Coverage 27.51% 27.51%
=======================================
Files 61 61
Lines 6272 6272
=======================================
Hits 1726 1726
Misses 4423 4423
Partials 123 123 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, if konnect control plane information was passed via cli flags, online validation for Konnect was failing. This change fixes the issue.