feat: support online validation with Konnect #1335
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1335 +/- ##
==========================================
- Coverage 27.65% 27.51% -0.14%
==========================================
Files 61 61
Lines 6241 6272 +31
==========================================
Hits 1726 1726
- Misses 4392 4423 +31
Partials 123 123 ☔ View full report in Codecov by Sentry. |
validate/validate.go
Outdated
| @@ -181,6 +181,9 @@ func (v *Validator) Validate(formatVersion semver.Version) []error { | |||
| if err := v.entities(v.state.FilterChains, "filter_chains"); err != nil { | |||
| allErr = append(allErr, err...) | |||
| } | |||
| if err := v.entities(v.state.Vaults, "vaults"); err != nil { | |||
There was a problem hiding this comment.
Sorry, I lack some context here. How is this addition related to this PR? @GGabriele
There was a problem hiding this comment.
ping: @GGabriele. Do you mind chiming in here? 🙇
There was a problem hiding this comment.
Vaults validation is currently completely missing from decK. This is not strictly related to the konnect implementation, so we can move it into a separate commit if we want.
There was a problem hiding this comment.
I'd prefer to extract it if that's the case.
Additionally, if possible I'd suggest to mark this with a comment why this is needed.
Also, this change adds a conditional that ensures that rbac flag used with konnect mode, gives an legible error to the user.
|
Other e2e tests for deck validate commands are added here: #1415 Kept this PR scoped to Konnect stuff. |
|
@pmalek Could you please help us with a review here? We have extended |
No description provided.