Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix konnect integration tests #1099

Merged
merged 1 commit into from
Nov 9, 2023
Merged

tests: fix konnect integration tests #1099

merged 1 commit into from
Nov 9, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Nov 9, 2023

Related issue: #1100

This PR mostly unblocks the CI so that it doesn't fail anymore. We can remove the konnect basic auth related functionality or fix it in a separate PR.

@pmalek pmalek added the testing label Nov 9, 2023
@pmalek pmalek self-assigned this Nov 9, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (77682ca) 32.91% compared to head (c208a01) 32.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1099   +/-   ##
=======================================
  Coverage   32.91%   32.91%           
=======================================
  Files         103      103           
  Lines       12834    12834           
=======================================
  Hits         4224     4224           
  Misses       8201     8201           
  Partials      409      409           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek marked this pull request as ready for review November 9, 2023 10:14
@pmalek pmalek requested a review from a team November 9, 2023 10:14
Copy link
Collaborator

@GGabriele GGabriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@pmalek pmalek merged commit f199564 into main Nov 9, 2023
35 checks passed
@pmalek pmalek deleted the fix-konnect-tests branch November 9, 2023 10:25
AntoineJac pushed a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants