Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exclude controller to admin comms from mesh #913

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Oct 23, 2023

What this PR does / why we need it:

Set Kuma and Istio outbound traffic excludes

Which issue this PR fixes

Part of Kong/kubernetes-ingress-controller#4698

Special notes for your reviewer:

See Kong/kubernetes-ingress-controller#4698 (comment) re design. The ingress chart subchart usage prevents us from automating the annotation value cleanly. It's unlikely it would need to change (we do expose the admin port configuration, but I don't know a reason you'd ever change it), but setting it in ingress's values.yaml runs the risk of accidentally excluding new annotations added in the kong chart values.yaml.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md ingress doesn't really use it?
  • Commits follow the Kong commit message guidelines

@rainest rainest marked this pull request as ready for review October 23, 2023 17:56
@rainest rainest requested a review from a team as a code owner October 23, 2023 17:56
@rainest rainest merged commit 824d022 into main Oct 24, 2023
23 checks passed
@rainest rainest deleted the feat/admin-mesh branch October 24, 2023 09:59
@pmalek
Copy link
Member

pmalek commented Oct 24, 2023

@rainest Can you elaborate what you mean by:

The ingress chart subchart usage prevents us from automating the annotation value cleanly

?

@pmalek
Copy link
Member

pmalek commented Oct 24, 2023

I guess this is the answer: Kong/kubernetes-ingress-controller#4698 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants