fix: Add inner exception (#4)

* add inner exception * Some annotation changes * Added some comments to silence the compiler
KonataDev · May 7, 2024 · 1ce3e76 · 1ce3e76
1 parent c166cb0
commit 1ce3e76
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 10 deletions.
diff --git a/Konata.Codec/Audio/Codecs/SilkV3Codec.cs b/Konata.Codec/Audio/Codecs/SilkV3Codec.cs
@@ -83,10 +83,10 @@ public override int Read(byte[] buffer, int offset, int count)
                     Position = 0;
                 }
 
-                // Catch native exceptions
-                catch
+                // Catch exceptions
+                catch (Exception e)
                 {
-                    throw new EncodeException("Thrown an exception while encoding silk.");
+                    throw new EncodeException("Thrown an exception while encoding silk.", e);
                 }
 
                 // Cleanup
@@ -165,10 +165,10 @@ public override int Read(byte[] buffer, int offset, int count)
                     Position = 0;
                 }
 
-                // Catch native exceptions
-                catch
+                // Catch exceptions
+                catch (Exception e)
                 {
-                    throw new EncodeException("Thrown an exception while decoding silk.");
+                    throw new EncodeException("Thrown an exception while decoding silk.", e);
                 }
 
                 // Cleanup

diff --git a/Konata.Codec/Audio/Codecs/VorbisCodec.cs b/Konata.Codec/Audio/Codecs/VorbisCodec.cs
@@ -11,6 +11,9 @@ namespace Konata.Codec.Audio.Codecs;
 /// </summary>
 public class VorbisCodec
 {
+    /// <summary>
+    /// Vorbis decoder
+    /// </summary>
     public class Decoder : AudioStream
     {
         private readonly VorbisReader _stream;

diff --git a/Konata.Codec/Audio/Codecs/WavCodec.cs b/Konata.Codec/Audio/Codecs/WavCodec.cs
@@ -124,6 +124,7 @@ public Decoder(Stream file)
         internal override AudioInfo? GetAdaptiveOutput()
             => _output;
 
+        /// <inheritdoc/>
         public override void Flush()
             => _stream.Flush();
 

diff --git a/Konata.Codec/Exceptions/DecodeException.cs b/Konata.Codec/Exceptions/DecodeException.cs
@@ -11,8 +11,9 @@ public class DecodeException : Exception
     /// Decode exception
     /// </summary>
     /// <param name="message"></param>
-    public DecodeException(string message)
-        : base(message)
+    /// <param name="inner"></param>
+    public DecodeException(string message, Exception inner = null)
+        : base(message, inner)
     {
     }
 

diff --git a/Konata.Codec/Exceptions/EncodeException.cs b/Konata.Codec/Exceptions/EncodeException.cs
@@ -11,8 +11,9 @@ public class EncodeException : Exception
     /// Encode exception
     /// </summary>
     /// <param name="message"></param>
-    public EncodeException(string message)
-        : base(message)
+    /// <param name="inner"></param>
+    public EncodeException(string message, Exception inner = null)
+        : base(message, inner)
     {
     }
 }