fix linkage on Xenial (16.04) #627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` /usr/bin/ld: libcc.a(libcc_a-cclib.o): relocation R_X86_64_32 against `.rodata.str1.8' can not be used when making a shared object; recompile with -fPIC libcc.a: error adding symbols: Bad value collect2: error: ld returned 1 exit status Makefile:2305: recipe for target 'komodod' failed make[2]: *** [komodod] Error 1 ```
|
While I think a PIC flag is a good idea, I cannot help but ask: "Why does anyone care about Xenial?". Xenial support for non-Pro subscribers ended its life some 3 years ago. |
Hmm... the answer is probably "because it costs zero effort," right? If we can support Xenial without any additional resources spent, why not? |
Given that everything automated is running 20/22, some additional resources are clearly spent going back 2 releases further. At that point, might as well also set it up for Trusty Tahr (since "technically" its full EoL isn't until April 2026), no? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes linkage error below on Xenial: