[release] v0.8.1 [Falkor] #600

ca333 · 2023-11-03T22:12:16Z

No description provided.

Update komodod_cd.yml

- https://curl.se/docs/CVE-2023-38545.html - https://curl.se/docs/CVE-2023-38546.html

the cross-compilation process in the rust komodo recipe differs slightly from the current native_rust recipe used in Zcash. therefore, we have commented out all invocations of the "update_stdlib_hash" function until the komodo rust recipe is updated.

todo: we still need rework rust integration, crates build, etc.

https://github.com/actions/runner-images/issues/6817 actions/setup-python#577

bump libcurl to 8.4.0

update rust to 1.69.0

as the bootstrap_url (https://sirseven.me/share/bootstrap.tar.gz) is no more accessible we will temp disable these jobs, until revise/rethink needed steps (mean, CC is kind of EOL, do we still need these tests here?) and re-create chains, if needed.

temp disable other tests to make debugging simpler. TODO: don't forget to enable them again.

TODO: add needed checks, also add komodoevents file check in all tests

__BYTE_ORDER != __LITTLE_ENDIAN

update KMD checkpoints

temp disable CC and basic RPC jobs in workflows

refactor old code (pax, kv, ratification, etc.)

bump version [0.8.1]

move extrabuf from condition block scope to the main komodo_args scope to avoid "dangling" pointer and garbage in buffer after exit from condition block. add proper init of variables.

For example, the group of test_block tests changes the value of IsInitialBlockDownload() to false after the first call to generateBlock. As a result, when komodo_connectblock is called, komodo_validate_chain should return 1 for the LegacyEvents tests. Additionally, if we are operating with various data directories between different tests, the static file pointer fp in komodo.cpp should be cleared between these tests to avoid writing to the same file in different tests.

smk762 · 2023-11-08T07:43:29Z

The Actions workflows output for linux fail to launch in Ubuntu 20.04

For the CI workflows:

./komodod: /lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.30' not found (required by ./komodod)
./komodod: /lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by ./komodod)
./komodod: /lib/x86_64-linux-gnu/libstdc++.so.6: version `CXXABI_1.3.13' not found (required by ./komodod)
./komodod: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by ./komodod)
./komodod: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by ./komodod)
./komodod: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by ./komodod)

For the CD workflow

./komodod: /lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.30' not found (required by ./komodod)

This (CD ouput) is pushed to https://hub.docker.com/r/komodoofficial/komodo and needed for use in the notary node docker setups. I'll see if I can find a resolution.

Note: Building locally on ubuntu20.04 following the readme resulted in usable binaries.

fix komodo_args, add ParseArgumentsTests, fix LegacyEvents test

DeckerSU · 2023-11-08T14:36:18Z

The Actions workflows output for linux fail to launch in Ubuntu 20.04

I believe that the komodo_linux_ci.yml workflow is failing because it's running on ubuntu-latest, which is currently ubuntu-22.04. The komodod_cd.yml workflow, however, is using ubuntu-20.04. To resolve this issue, we should either use Ubuntu 20.04 in both workflows or build for multiple GLIBC versions, as I have done in the KomodoOcean repository. The KomodoOcean builds successfully with Xenial (and works on Xenial and later releases) as well as Focal. The release binaries include both builds.

DeckerSU

LGTM. We might want to consider changing runs-on: ubuntu-latest to runs-on: ubuntu-20.04 in the komodo_linux_ci.yml file to align it with komodod_cd.yml.

smk762 · 2023-11-10T09:54:39Z

https://github.com/KomodoPlatform/komodo/actions/runs/6799081197 output fails to launch for Mac with error below :

maybe we need to use macos-11 for builds instead of macos-latest. I'll test this and PR CI/CD updates accordingly.

Device specs:

DeckerSU · 2023-11-10T10:07:51Z

It's because komodod file content is not even Mach-O 64-bit executable x86_64:

I remember that this issue exists due to incompatibility or a mismatch between the Rust and XCode versions. Switching to macos-11 should resolve the problem.

update dockerfiles

ca333 · 2023-11-14T12:01:51Z

maybe we need to use macos-11 for builds instead of macos-latest. I'll test this and PR CI/CD updates accordingly.

yes best is to build with "older" (sec patched / supported) version for wider (backwards) compatibility

DeckerSU · 2024-03-10T21:41:21Z

maybe we need to use macos-11 for builds instead of macos-latest. I'll test this and PR CI/CD updates accordingly.

Issue resolved. The root cause was identified as bsdtar on MacOS, which was causing file corruption during archive creation.

smk762 and others added 30 commits July 1, 2023 10:14

Update komodod_cd.yml

4dd2b0a

Merge pull request #590 from KomodoPlatform/Run-CD-on-push-to-master

657cc69

Update komodod_cd.yml

bump libcurl to 8.4.0

01da71a

- https://curl.se/docs/CVE-2023-38545.html - https://curl.se/docs/CVE-2023-38546.html

add update-rust-hashes.sh script

2b28926

the cross-compilation process in the rust komodo recipe differs slightly from the current native_rust recipe used in Zcash. therefore, we have commented out all invocations of the "update_stdlib_hash" function until the komodo rust recipe is updated.

depends: update rust to 1.69.0

cfe8d56

todo: we still need rework rust integration, crates build, etc.

mac ci: try to fix brew upgrade / existing links

23a22d6

https://github.com/actions/runner-images/issues/6817 actions/setup-python#577

mac ci: remove redundant unlink for node

3f98ecd

build: mac, suppress deprecated declarations warning

642c698

update KMD checkpoints

fcb431a

Merge pull request #594 from DeckerSU/patch-bump-libcurl

cc237be

bump libcurl to 8.4.0

Merge pull request #595 from DeckerSU/patch-bump-rust

9d8c5f6

update rust to 1.69.0

update assetchains.old, remove old (deprecated) chains

e42444f

add events related unit tests

a6ce7c8

add NormalKMDLTCNota unit test

9c32d6e

add advanced clear of all variables between tests

0ecea4a

add MIL->KMD notarisation test (3p coin nota test)

13ea74e

temp disable other tests to make debugging simpler. TODO: don't forget to enable them again.

add MARTY->KMD notarisation test (AC nota test in KMD chain)

e06aa5b

add MARTY->KMD notarisation test (AC nota test in MARTY chain)

3479410

TODO: add needed checks, also add komodoevents file check in all tests

enable all tests, add missed checks

00cb01d

correct opretlen calculations for BIG_ENDIAN

81581d0

__BYTE_ORDER != __LITTLE_ENDIAN

remove deprecated KV OPRET in assetchains

ce4d344

fix PhantomOpReturnEvent test

e5023e2

refactor opret chain search and compare

b435ecc

more get rid of strcmp in komodo_voutupdate

54ebb28

get rid of legacy PAX related specific oprets

c645cb6

remove unneded OtherTest

b8678b4

limit the scope of ratification transactions to KMD

e94d98d

komodo_voutupdate: don't try to process staking oprets and notary proofs

2d5f55b

bump version [0.8.1]

40475ad

ca333 added 4 commits November 3, 2023 23:06

Merge pull request #596 from DeckerSU/patch-update-checkpoints

5e362af

update KMD checkpoints

Merge pull request #597 from DeckerSU/patch-disable-ci-jobs

bac0096

temp disable CC and basic RPC jobs in workflows

Merge pull request #598 from DeckerSU/patch-refactor-old-code

3212c3c

refactor old code (pax, kv, ratification, etc.)

Merge pull request #599 from DeckerSU/patch-version-bump

b3e9e1f

bump version [0.8.1]

ca333 requested review from DeckerSU, smk762 and Alrighttt November 4, 2023 19:34

DeckerSU added 7 commits November 7, 2023 00:53

komodo_args: fix rpc and p2p port in ACs on MacOS

72a6df2

move extrabuf from condition block scope to the main komodo_args scope to avoid "dangling" pointer and garbage in buffer after exit from condition block. add proper init of variables.

tests: add ParseArgumentsTests for komodo_args / chainparams_commandline

8640b82

tests: fix ParseArgumentsTests initializer list issue

6a8112c

tests: KomodoFeatures fix missed override keyword for member- functions

232b422

tests: add missed fs namespace

3217da4

test: improve mapBlockIndex cleanup in LegacyEventsTests

aceb7c7

Merge pull request #601 from DeckerSU/patch-parse-arg-test

c86da4d

fix komodo_args, add ParseArgumentsTests, fix LegacyEvents test

DeckerSU approved these changes Nov 8, 2023

View reviewed changes

smk762 added 4 commits November 9, 2023 13:55

update dockerfiles

f38c6f0

use ubuntu-20.04 for CI/CD

fc6804b

rm / unlink breaking brews

c470b18

use ubuntu-latest for win builds

bd682c8

Alrighttt approved these changes Nov 13, 2023

View reviewed changes

Merge pull request #603 from KomodoPlatform/update-CD

c248b15

update dockerfiles

ca333 merged commit d9144d0 into master Nov 14, 2023
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release] v0.8.1 [Falkor] #600

[release] v0.8.1 [Falkor] #600

ca333 commented Nov 3, 2023

smk762 commented Nov 8, 2023 •

edited

Loading

DeckerSU commented Nov 8, 2023

DeckerSU left a comment

smk762 commented Nov 10, 2023

DeckerSU commented Nov 10, 2023 •

edited

Loading

ca333 commented Nov 14, 2023

DeckerSU commented Mar 10, 2024

[release] v0.8.1 [Falkor] #600

[release] v0.8.1 [Falkor] #600

Conversation

ca333 commented Nov 3, 2023

smk762 commented Nov 8, 2023 • edited Loading

DeckerSU commented Nov 8, 2023

DeckerSU left a comment

Choose a reason for hiding this comment

smk762 commented Nov 10, 2023

DeckerSU commented Nov 10, 2023 • edited Loading

ca333 commented Nov 14, 2023

DeckerSU commented Mar 10, 2024

smk762 commented Nov 8, 2023 •

edited

Loading

DeckerSU commented Nov 10, 2023 •

edited

Loading