fix(ui): align asset selector styling and improve dark mode appearance #2605
+270
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tab overlaying coin price and the Asset management text not visible in Light theme mode.
Changed the Asset management to look like the other UiPrimary buttons. Added spacing for the Market Chart header so it does not look like it is overlaying on the price.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
TazzyMeister
changed the title
This update improves the style and layout of the selected coin graph control in the dropdown version to share the same style to keep it consistent. - Adjusted dropdown styling to look like divided button styling. - Added padding so the Asset Icon matches the down arrow icon
…to segmented button - Introduced `DropdownWithSearch` widget to replace the default dropdown in `SelectedCoinGraphControl` when in compact mode. - Styled the dropdown to visually match the segmented button including color, border, padding, and radius. - Replaced `collection`'s `firstWhereOrNull` with native Dart fallback to avoid adding external dependencies. - Improved spacing of the AssetIcon to match layout expectations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses segmented button overlapping coin price and being cut off. Changed Asset Management button on wallet page to be more visible on light mode and to look more like other buttons.