Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync KomodoPlatform/coins config+icons #96

Merged
merged 6 commits into from
Jan 19, 2024
Merged

Sync KomodoPlatform/coins config+icons #96

merged 6 commits into from
Jan 19, 2024

Conversation

CharlVS
Copy link
Member

@CharlVS CharlVS commented Jan 18, 2024

Sync coin config files and icon images used to populate the list of coins in-app

@CharlVS CharlVS added the QA Ready for QA testing label Jan 18, 2024
@CharlVS CharlVS self-assigned this Jan 18, 2024
@CharlVS CharlVS requested review from smk762 and kivqa January 18, 2024 14:10
ad111bd842cdc6a6f0f0dcb55abcde7e56c3e266
@CharlVS CharlVS changed the base branch from master to dev January 18, 2024 14:13
smk762
smk762 previously approved these changes Jan 18, 2024
kivqa
kivqa previously approved these changes Jan 18, 2024
Copy link

@kivqa kivqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. HASH is correct. Non-sewgit coins are available for swap

@kivqa kivqa self-requested a review January 18, 2024 16:33
@kivqa
Copy link

kivqa commented Jan 18, 2024

@smk762 looks like return non-segwit coin breaks Swap->Advanced functionality. Impossible to select Receive coin

@smk762 smk762 dismissed stale reviews from kivqa and themself via 8a989c7 January 18, 2024 17:45
@ca333 ca333 merged commit 3a835dc into dev Jan 19, 2024
1 check failed
@smk762
Copy link
Contributor

smk762 commented Jan 19, 2024

It is working here with latest local build. Make sure to completely uninstall any prior builds before building/installing the latest, there may be some leftover cache otherwise.

Screen_Recording_20240119_015149.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Ready for QA testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants