Update netid, coins and bump app version #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though coin config files are updated at runtime, it’s a good idea to keep the bundled version up to date since it’s used on the first launch and is used as a fallback if update fails. NB: In the near future, these files will be dropped from the repo and instead rather fetched at CI build time in PR #87 (#87).
Major release version because net ID update is a breaking change since users on old net ID cannot see order book of new net ID users. This is part of a p2p network stack upgrade for Komodo DeFi framework which opens up future possibilities for more efficient streaming-based event features.
CharlVS
changed the title
0.9.0)
CharlVS
changed the title
0.9.0)The new Komodo DeFi Framework p2p layer changes require Android NDK >=23.
CharlVS
added
the
0.9.0
ca333
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Net ID
Major (semver) release version because net ID update is a breaking change since users on old net ID cannot see the order book of new net ID users. This is part of a p2p network stack upgrade for Komodo DeFi framework, which opens up future possibilities for more efficient streaming-based event features.
Update coin config and icon files. Even though coin config files are updated at runtime, it’s a good idea to keep the bundled version up to date since it’s used on the first launch and is used as a fallback if the update fails. Also, some coin authors for new coins have been waiting for us to push an update because their icon is missing from the app because icons are not updated at runtime.
NB: In the near future, coin config and icon files will be dropped from the repo and instead fetched at CI build time in PR Optimise coins asset files #87
Upgrade min Android SDK version to fix failed builds. New DeFi version requires newer Android NDK version: https://github.com/KomodoPlatform/komodo-defi-framework/blob/092d562f476ece1bef3cf3e8e50694e23688dade/scripts/ci/android-ndk.sh#L5-L6