update proxy and candles urls #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kivqa Everything working as expected? |
|
Checking of this PR blocked by issue with API. https://candles.komodo.earth/api/v1/ohlc/eth-btc and https://komodo.earth:3333/api/v1/ohlc/eth-btc returns |
|
We are still awaiting to find an alternate candlestick provider. The new provider is no longer available. |
|
https://binance-docs.github.io/apidocs/spot/en/#kline-candlestick-streams is an option with wide support for coins, though due to their API limit policies, this should be implemented client side. |
|
Due to an issue with the new API provider, this was abandoned in favour of implementing Binance's API, which includes some minor improvements/fixes by @takenagain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little housekeeping.
komodo.earth:3334 -> etherscan-proxy.komodo.earth
komodo.earth:3333 -> candles.komodo.earth
Old urls still work, for now. This repo is the last one still using the old ones. No rush on review / merge, but should be included in the next release.
To test: