General ARRR bug fixes and UI improvements #77

CharlVS · 2023-10-11T17:58:35Z

Make the ZHTLC activation process more resilient to being interrupted and for app restarts. And other bugs which were later discovered.

Changelog:

Fix an issue where resuming the iOS app after minimizing it would cause ARRR/ZHTLC to deactivate. The app now resyncs ARRR after minimizing.
ARRR/ZHTLC: Hide sapling activation mode unless test coins are enabled.
Rename some methods/variables and remove unused code.
Minor ZHTLC UI/UX improvements.
Set expiry for rebranding notice (November 2023).
Implement ZHTLC coin disable/deactivation.
Fixed pagination. Previously only 10 transactions max were shown. Now it will show as many as your fingers can scroll.
Fix issue where disabled ZHTLC coins would re-activate after restart.
Simplify coin details transactions list page.
So many other improvements. See commit history

To test (on iOS and Android):

Test successful initial activation of the various ARRR/ZOMBIE activation modes. Testing sapling mode activation is not required.
For past-date sync mode: After successful activation, restart the app and check that ZHTLC resyncs and transactions show.
Check that sapling activation mode only shows when test coins mode is enabled.
(Optional since the user is warned against it) Test what happens if the app is restarted during initial activation and during resync. We should be able to drop the warnings to the user not to do this since we can safely handle it.

Fix iOS warning text style and re-organise form order so that the date picker is below the associated option to indicate that the date select is associated with the second option.

- Remove unused code. - Fix minor ZHTLC bugs. Patch one down, pass it around…

Format code for files touched in PR (NO FUNCTIONAL CHANGES IN THIS COMMIT)

kivqa · 2023-10-12T15:04:40Z

Text on cancel activation pop up have to be placed on 2 lines

Tweak activation ETA calculation to be less sensitive

Fix issue where incorrect localisation messages were used and also that UX was confusing because ZHTLC activation cancellation dialog had “Cancel” and “Confirm Cancel” buttion actions.

Fix ZHTLC progress always showing 100% when resuming sync for an interrupted initial sync.

Fix a bug where there would be a sigificant delay in the dialog opening when tapping the ZHTLC activation banner.

kivqa · 2023-10-12T20:11:49Z

Deactivatoin broken, after app restart resync starts again and ARRR appears in the asset least

kivqa · 2023-10-13T05:55:08Z

Test results:
Initial activation

Observed issues on initial activation:

ZHTLC coin activation banner on the top does not disappear after activation completed (not 100% reproducibility), could be fixed by app restart
Add coin button does not work sometimes. Exact steps are not cleat yet. Add coin button replaced by spinner when I tap (+) button and nothing happens, I waited few minutes
Cancel activation button disappeared in case initial activation interrupted by app restarting. So user cant cancel activation in case if specified selected date is too old. Actually this operation could be canceled only if user re-import wallet

Activated ZHTLC coin:

Resync

Resync ZHTLC coin on app restart on Android - works correctly
Resync ZHTLC coin on app restart on iOS - works correctly
Resync ZHTLC coin on app minimize/resume on Android - no need resync, ZHTLC coins do not affected by minimize/resume
Resync ZHTLC coin on app restart on iOS - resync started and completed successfully on minimize/resume, ZHTLC coins works as expected after that

App minimize/resume

ARRR History is displayed in case app resumed on Android - works correctly
ARRR History is displayed in case app resumed on iOS - works correctly
User can send ARRR in case app resumed on Android - works correctly
User can send ARRR in case app resumed on iOS - works correctly

Upgrade the minimum Flutter version. This will likely not change the Dart/Flutter version used for deployments but is needed to ensure we do not deploy with an unnecessarily old version and ensure we can access Dart’s `.ignore()` method.

- Fix “Cancel Activation” not showing for initial activation if restarted. - Possibly fix issue causing infinite loading of “add coins” floating action button. - Smooth out big progress changes. - Other minor fixes.

kivqa · 2023-10-13T17:45:37Z

@CharlVS I found one scenario for endless loader on Add asset button click

Launch and login to the app
Click on bottom menu button Dex -> Market -> Porfolio
Click (+) Add asset button
result: Endless spinner
applicable for both platforms

Fix bug in multi-coin activation progress and better document the logic in the progress calculation.

- Create and use an animated linear progress bar for the ZHTLC progress bar. - Animate the appearance and disappearance of the ZHTLC progress banner.

- Ensure the activation dialog closes when complete - Minor tweaks to ETA calculation

Create a re-usable Floating Action Button (FAB) which when tapped while not ready, will display a circular progress loader. If the FAB becomes ready after being tapped, the provided `onTap` callback will be triggered automatically. This is useful to give the user the idea that the loading isn’t happening unless they tap the button before the loading is complete. This is created so that it can be used for the Add coin FAB.

Fix infinite loader for “Add coins” button and refactor to use the new re-usable eager loading FAB widget.

- Fix bug where the coins page would only load the first 10 transactions and not load more transactions when scrolled to the bottom of the list. There is also other refactoring for the coin details screen, but the root cause of the issue was improper use of layouts scrollable areas. NB! A significant portion of the code in this commit’s diff is unchanged except for being moved as part of the refactoring. Dig deeper into the commit history for more info on the origin of this code. Using helper widget methods instead of separate widgets is not a good practice.

Move widget for animated collapse to own file + other improvements.

Fix - Fix v2 and ZHTLC pagination + refactor

kivqa · 2023-10-15T15:12:59Z

@CharlVS
Checked last commits: tickers were not loaded on Profile page and asset details screen for some reason checked iOS and Android builds
Other changes and activation still in testing.

Clean up coin info page header buttons (Send, receive, faucet, claim, pub key)

smk762 · 2023-10-16T05:20:07Z

Looking mostly good here. Process kicks on after app restart / phone reboot.
TX history display is visible and works as expected. I was able to do a swap without a problem.

I seem to be unable to do any withdrawals (on both KMD and ARRR). Nothing related seen in logs to indicate cause. This problem persisted after rebooting phone.

Screen_Recording_20231016_131215.mp4

There's some ambiguity when activating ARRR and ZOMBIE at the same time, though its not critical as ZOMBIE is just test coin.

Zombie remains on menu for selection if activated, then disabled, and text coin setting toggled off. Non critical.
I'm not sure what the PIRATE (ZHTLC) Activation bit in settings is for. Nothing happens when I tap on it. Is it a remnant that can be removed?

kivqa

Approved. ZHTLC activation worked as expected. Known issues were fixed

smk762

Thanks for the huge effort! Withdraw issues resolved and pirate functioning.

naezith and others added 8 commits October 10, 2023 13:46

zhtlc allow resync on app resume

764461a

Fix iOS warning text style and re-organise form order

06c162c

Fix iOS warning text style and re-organise form order so that the date picker is below the associated option to indicate that the date select is associated with the second option.

Minor bug fixes and improved error handling

d31b04c

Improve performance of RPC status checking

633c954

Only show sapling activation in developer mode

81ebdd3

Make ZHTLC activation banner less scary

7f193e7

Bug: Tweak ZHTLC resync logic to fix iOS error

8df0d44

Silence ZHTLC progress notifications

25900ab

CharlVS added the bug Something isn't working label Oct 11, 2023

CharlVS self-assigned this Oct 11, 2023

CharlVS added 2 commits October 12, 2023 14:31

Remove unused code & fix minor ZHTLC bug

1ceffdf

- Remove unused code. - Fix minor ZHTLC bugs. Patch one down, pass it around…

Formatting changes

7cf98b7

Format code for files touched in PR (NO FUNCTIONAL CHANGES IN THIS COMMIT)

CharlVS requested a review from kivqa October 12, 2023 12:36

CharlVS marked this pull request as ready for review October 12, 2023 12:36

CharlVS added the QA Ready for QA testing label Oct 12, 2023

smk762 self-requested a review October 12, 2023 14:06

CharlVS added 5 commits October 12, 2023 19:19

Tweak activation ETA calculation

46c77fc

Tweak activation ETA calculation to be less sensitive

Fix confusing ZHTLC dialog localisations

22cbc71

Fix issue where incorrect localisation messages were used and also that UX was confusing because ZHTLC activation cancellation dialog had “Cancel” and “Confirm Cancel” buttion actions.

Bug - Fix ZHTLC progress always showing 100%

e624866

Fix ZHTLC progress always showing 100% when resuming sync for an interrupted initial sync.

Bug - Fix ZHTLC progress dialog not opening

cae3b68

Fix a bug where there would be a sigificant delay in the dialog opening when tapping the ZHTLC activation banner.

Easter?

ead91e9

Add expiration on rebranding notice

ca126d7

CharlVS force-pushed the zhtlc-resync-on-resume branch from 03c5fcb to c0588f5 Compare October 12, 2023 20:29

Fix - Disabled Z coins would be re-activated on launch

25f4758

CharlVS force-pushed the zhtlc-resync-on-resume branch from c0588f5 to 25f4758 Compare October 12, 2023 20:35

CharlVS added 2 commits October 13, 2023 16:46

Upgrade minimum Flutter/Dart version

88aaa0b

Upgrade the minimum Flutter version. This will likely not change the Dart/Flutter version used for deployments but is needed to ensure we do not deploy with an unnecessarily old version and ensure we can access Dart’s `.ignore()` method.

Minor ZHTLC bug fixes

b9063c4

- Fix “Cancel Activation” not showing for initial activation if restarted. - Possibly fix issue causing infinite loading of “add coins” floating action button. - Smooth out big progress changes. - Other minor fixes.

CharlVS added 14 commits October 13, 2023 22:08

Fix bug in multi-coin activation progress

2bae627

Fix bug in multi-coin activation progress and better document the logic in the progress calculation.

Animate activation progress

96ec18e

- Create and use an animated linear progress bar for the ZHTLC progress bar. - Animate the appearance and disappearance of the ZHTLC progress banner.

Ensure ZHTLC dialog closes when complete

75f51f5

- Ensure the activation dialog closes when complete - Minor tweaks to ETA calculation

Bug - Fix infinite loader for “Add coins” button

76204ed

Fix infinite loader for “Add coins” button and refactor to use the new re-usable eager loading FAB widget.

Move widget for animated collapse to own file

97460c9

Move widget for animated collapse to own file + other improvements.

Make rotating progress indicator more Google-like

a295653

Bug - Fix v2 txs and ZHTLC pagination + refactor

713d950

Fix - Fix v2 and ZHTLC pagination + refactor

Simplify transactions list items

50f569a

UX tweaks for rotating progress indicator

b20b7c7

Bug - Improve CEX error handling

420c346

Show contrast between tx address and note

d5f80b1

Increase Tx send/receive icon size

38c1c44

CharlVS added 3 commits October 15, 2023 18:00

Bug - fix improved error handling

5441004

Show tx list scroll bar

407faba

Clean up coin info page header buttons

2458088

Clean up coin info page header buttons (Send, receive, faucet, claim, pub key)

CharlVS added 3 commits October 16, 2023 09:41

Bug - fix withdraw form not working

b5dc66b

Remove ZHTLC status from settings list

3cf0f91

Fix shadows on overflowed button text

ac86dc3

kivqa approved these changes Oct 16, 2023

View reviewed changes

smk762 approved these changes Oct 16, 2023

View reviewed changes

CharlVS merged commit 53d67ad into dev Oct 16, 2023
1 check failed

CharlVS deleted the zhtlc-resync-on-resume branch October 16, 2023 10:42

CharlVS changed the title ~~Bug - Fix iOS ARRR Broken After App Resume~~ General ARRR bug fixes and Oct 16, 2023

CharlVS changed the title ~~General ARRR bug fixes and~~ General ARRR bug fixes and UI improvements Oct 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

General ARRR bug fixes and UI improvements #77

General ARRR bug fixes and UI improvements #77

CharlVS commented Oct 11, 2023 •

edited

Loading

kivqa commented Oct 12, 2023

kivqa commented Oct 12, 2023

kivqa commented Oct 13, 2023 •

edited

Loading

kivqa commented Oct 13, 2023 •

edited

Loading

kivqa commented Oct 15, 2023 •

edited

Loading

smk762 commented Oct 16, 2023 •

edited

Loading

kivqa left a comment

smk762 left a comment

General ARRR bug fixes and UI improvements #77

General ARRR bug fixes and UI improvements #77

Conversation

CharlVS commented Oct 11, 2023 • edited Loading

Changelog:

To test (on iOS and Android):

kivqa commented Oct 12, 2023

kivqa commented Oct 12, 2023

kivqa commented Oct 13, 2023 • edited Loading

kivqa commented Oct 13, 2023 • edited Loading

kivqa commented Oct 15, 2023 • edited Loading

smk762 commented Oct 16, 2023 • edited Loading

kivqa left a comment

Choose a reason for hiding this comment

smk762 left a comment

Choose a reason for hiding this comment

CharlVS commented Oct 11, 2023 •

edited

Loading

kivqa commented Oct 13, 2023 •

edited

Loading

kivqa commented Oct 13, 2023 •

edited

Loading

kivqa commented Oct 15, 2023 •

edited

Loading

smk762 commented Oct 16, 2023 •

edited

Loading