Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ibc withdraw method #284

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

add ibc withdraw method #284

wants to merge 10 commits into from

Conversation

smk762
Copy link
Contributor

@smk762 smk762 commented Jul 17, 2024

closes #283

I had this commit unpushed from earlier, so not 100% sure it is complete. Please advise if any issue while testing, or if you notice anything missing.

Copy link

Preview for merge commit: 543bc93, available on cloudflare at: https://0f9b4a2c.komodo-docs.pages.dev/en/docs/

smk762 and others added 2 commits July 17, 2024 09:06
…nks, formatted md content, checked presence of file and dirs based on sidebar, checked presence of h1 in every file, update Komodo DeFi Framework methods table, adds/updates preview images when base is main
Copy link

Preview for merge commit: b8ab087, available on cloudflare at: https://ef1b6bde.komodo-docs.pages.dev/en/docs/

src/pages/komodo-defi-framework/api/v20/withdraw/index.mdx Outdated Show resolved Hide resolved
Comment on lines 574 to 575
"coin": "ATOM-IBC_NUCLEUSTEST",
"to": "nuc16ggf7pmy0w0glzyrgd2x9mlw92csw6d9yj2qvg",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should make it more clear

Suggested change
"coin": "ATOM-IBC_NUCLEUSTEST",
"to": "nuc16ggf7pmy0w0glzyrgd2x9mlw92csw6d9yj2qvg",
"coin": "ATOM",
"to": "iaa1e0rx87mdj79zejewuc4jg7ql9ud2286g2us8f2",

Copy link

Preview for merge commit: 9a4e739, available on cloudflare at: https://f1cb7375.komodo-docs.pages.dev/en/docs/

Copy link

Preview for merge commit: 610011d, available on cloudflare at: https://9ca728bb.komodo-docs.pages.dev/en/docs/

Copy link

Preview for merge commit: b72a5e0, available on cloudflare at: https://e047cc43.komodo-docs.pages.dev/en/docs/

Copy link

Preview for merge commit: 1e3768f, available on cloudflare at: https://f77a3b23.komodo-docs.pages.dev/en/docs/

@smk762 smk762 added P1 Important task which needs to be completed soon awaiting review labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review P1 Important task which needs to be completed soon v2.1.0-beta-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants