check status of peers in kdf network #25
Conversation
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
src/expirable_map.rs
Outdated
| /// WARNING: This is designed for performance-oriented use-cases utilizing `FxHashMap` | ||
| /// under the hood and is not suitable for cryptographic purposes. | ||
| #[derive(Clone, Debug)] | ||
| pub struct ExpirableMap<K: Eq + Hash, V>(FxHashMap<K, ExpirableEntry<V>>); |
There was a problem hiding this comment.
ExpirableMap object and its methods are duplicated in KomodoDeFi repo. https://github.com/KomodoPlatform/komodo-defi-framework/blob/14eeaeeb3da0745f7f4af1bf241e9c2d8755bc50/mm2src/common/expirable_map.rs
Can we have it as a dep, like you did with proxy sig?
proxy_signature = { git = "https://github.com/KomodoPlatform/komodo-defi-framework", rev = "9ebc006" }
There was a problem hiding this comment.
I didn't want to add the large common crate from KDF just to use this simple module.
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
|
|
||
| ### Architecture (TODO: OUTDATED) | ||
| ### Architecture |
There was a problem hiding this comment.
Could you plz add some intro to the README about how this service is used?
Is it basically for KDF app to access backends (web3, quicknode etc providers)?
Will it be a network of proxies or each KDF peer will have its own proxy locally?
There was a problem hiding this comment.
Could you plz add some intro to the README about how this service is used?
Sure.
Is it basically for KDF app to access backends (web3, quicknode etc providers)?
Yes, we use this to hide the keys for our paid services and protect them from misuse. You can take a look on https://gist.github.com/onur-ozkan/725f56c05a2eb01e0428f03191f8da86 for some more context.
Will it be a network of proxies or each KDF peer will have its own proxy locally?
No.
There was a problem hiding this comment.
Could you plz add some intro to the README about how this service is used?
Done that.
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Yeah, nightly clippy is broken. |
|
@onur-ozkan you can merge this PR now :) |
KomodoPlatform/komodo-defi-framework#2194 is kind a blocker for this PR. Due to some recent breaking changes in that PR, I had to do this change in this PR. Same can happen again, so I will wait until we merge KomodoPlatform/komodo-defi-framework#2194. |
|
@onur-ozkan in the proxy repo could we use some expirable map improvements provided in this discussion thread KomodoPlatform/komodo-defi-framework#2232 (comment) ? |
I will, waiting for final result. |
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Implements KomodoPlatform/komodo-defi-framework#2194