feat(new-RPC): Add get_wallet RPC for Retrieving Active Wallet

[CharlVS]

Description: Add get_wallet RPC Method for Retrieving Active Wallet Information

This PR introduces the get_wallet RPC method, which allows clients to retrieve information about the currently active wallet. While the initial implementation returns the wallet name, the design is extensible to support additional wallet properties in future updates.

Key Features:

• get_wallet_rpc Method: Retrieves the active wallet's name and can be expanded to return more wallet-specific data.
• Flexible Request Handling: The GetWalletRequest struct is currently empty but prepared for future request parameters.
• Extensible Response Structure: The GetWalletResponse struct currently includes the wallet name but is designed to be expanded for future needs.

[laruh]

Thanks, for the PR. did a brief review

[laruh]

there is no need to add params and return sections in doc comment for get_wallet_rpc function.

we prefer to add doc comms right above the params and return types: GetWalletRequest, GetWalletResponse, GetWalletError

so you can remove Parameters and Returns and Examples :)

[shamardy]

I guess @CharlVS was following the get_mnemonic_rpc example, I was trying different things back then when I implemented it. I wanted also to have request/response examples in docs e.g.

komodo-defi-framework/mm2src/mm2_main/src/lp_wallet.rs

Lines 330 to 357 in 7723b50

	/// `GetMnemonicRequest` is a struct representing a request to get a mnemonic.
	///
	/// It contains a single field, `mnemonic_format`, which is an instance of the `MnemonicFormat` enum.
	/// The `#[serde(flatten)]` attribute is used so that the fields of the `MnemonicFormat` enum are included
	/// directly in the `GetMnemonicRequest` when it is deserialized, rather than nested under a
	/// `mnemonic_format` field.
	///
	/// # Examples
	///
	/// For a `GetMnemonicRequest` where the `MnemonicFormat` is `Encrypted`, the JSON representation would be:
	/// ```json
	/// {
	/// "format": "encrypted"
	/// }
	/// ```
	///
	/// For a `GetMnemonicRequest` where the `MnemonicFormat` is `PlainText` with a password of "password123", the JSON representation would be:
	/// ```json
	/// {
	/// "format": "plaintext",
	/// "password": "password123"
	/// }
	/// ```
	#[derive(Debug, Deserialize)]
	pub struct GetMnemonicRequest {
	#[serde(flatten)]
	pub mnemonic_format: MnemonicFormat,
	}

But I guess API docs will be moved from docs repo to KDF and we won't need this. Thanks for trying to keep docs consistent @laruh we need to have a consistent way of writing docs across all modules. I am working on this implementation in a different branch anyway and will be opening another PR this week, just wanted to clarify this point here :)

[laruh]

you should remove empty line

[laruh]

you can leave param like this, no need to define new variable if you dont use it.

pub async fn get_wallet_rpc(
    ctx: MmArc,
    _req: Option<GetWalletRequest>, // Just pass it through
) -> MmResult<GetWalletResponse, GetWalletError> {
    let wallet_name = ctx
        .wallet_name
        .clone_or(None)
        .ok_or(GetWalletError::WalletNameNotInitialized)?;

    Ok(GetWalletResponse { wallet_name })
}

[laruh]

if the purpose is to get wallet info, I suggest to use a clearer RPC name, eg get_wallet_info.

Description: Add get_wallet RPC Method for Retrieving Active Wallet Information

same for GetWalletError and GetWalletRequest types. You can have GetWalletInfoError and GetWalletInfoReq

[shamardy]

Superseded by #2202