Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide EVM NFT configs #1061

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Conversation

laruh
Copy link
Member

@laruh laruh commented May 31, 2024

related to #1115

note: coins json was beautified that's why it has some additional changes

related to this PR KomodoPlatform/komodo-defi-framework#2129

@laruh
Copy link
Member Author

laruh commented Jun 2, 2024

@shamardy could you also review this PR during the review week, please

@cipig
Copy link
Member

cipig commented Aug 17, 2024

what about derivation_path?
shouldn't it be the same for all chains?
#1083 updates all paths to m/44'/60'

@smk762 smk762 changed the base branch from dev to master September 3, 2024 07:03
@smk762
Copy link
Collaborator

smk762 commented Sep 3, 2024

what about derivation_path? shouldn't it be the same for all chains? #1083 updates all paths to m/44'/60'

We can resolve this in the other PR

@smk762 smk762 merged commit 1741fb7 into KomodoPlatform:master Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants