You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything seems to be falling into place. Overall, I notice that to consume the backend correctly, I must pass the ChainID.
I'll to Merge this PR to start working on it!
Re: unit tests
I fixed two type errors that I introduced in this PR in my last commit (thanks for pointing me at tests once more!). However the unit tests still fail, which is expected. Imo the problem is the RPC rate limitations by Alchemy. The tests use forks of goerli / mainnet, which in turn rely on that external RPC. In my last PR, I tried to use a free plan API key (I also added it to the Github CI), but unfortunately the free plan doesn't allow for a sufficient amount of requests for the tests to run through. Because this is the only issue that I'm currently having with RPC call rate limits, I'm hesitant to switch over to a paid plan atm. Instead, I would say let's live with the failing tests for now and merge.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ticket: https://www.notion.so/kolektivo/Fix-join-exit-pool-4dfe0c0669204f8f8535ad90c04916a8?pvs=4