fix: pluralization not being used for duration translations #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You mean it's literally outputting |
Yes |
|
What does |
|
|
|
Found the problem, I'm not passing KnpTimeBundle/src/DateTimeFormatter.php Line 76 in 3fe7960 |
kbond
changed the title
weaverryan
reviewed
Jul 31, 2023
| $this->assertStringContainsString("Less than a second: < 1 second\n", $result); | ||
| $this->assertStringContainsString("One second: 1 second\n", $result); | ||
| $this->assertStringContainsString("Multiple seconds: 59 seconds\n", $result); | ||
| $this->assertStringContainsString("One minute: 1 minute\n", $result); |
There was a problem hiding this comment.
What about 61 seconds? Does that still say 1 minute? Same for 1 hour and 1 minute (e.g. 3660 seconds)
There was a problem hiding this comment.
Does that still say 1 minute?
Yes, I added some tests for this.
weaverryan
force-pushed
the
pluralization
branch
from
4198fc0
to
924d84b
Compare
|
Thanks Kevin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pluralization is not being triggered for the new duration translations:
{{ 1|duration }} {# 1 second|%count% seconds #} {{ 2|duration }} {# 2 seconds #}I can't immediately see the issue...