Refactor configuration/option flags from config file. Add placeholder flags for (property) array generation and PATCH path #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for renaming this is because 1) all the variables referred to is as "path generator" anyway and 2) to avoid confusion with java.nio.file.Path
Mostly refactoring. Added PATCH placeholder and a new ALWAYS_GENERATE_ARRAYS flag to be used soon. This is basically a patch without any functionality changes.
|
Will have a look by next week (I am on holidays this week). Looking promising! |
dgarijo
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding
default_descriptionsanddefault_propertiesflags, I had an idea to have a flag for enabling/disabling generation of examples (mostly helpful when checking that ontology/OpenAPI spec are as desired).Based on another PR, I plan to add a flag for flipping between arrays or single type/value properties.
Given that some additional flags may also be desired in the future, I thought we could improve the way these flags are passed around in the code. After some investigation, it appeared that creating a map in the
YamlConfigclass with an enum flagCONFIG_FLAGfor the key and a Boolean value would be the best. Then, whenever we need a value, we can grab it from the config variable.