Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dependencies/plugins; plus junit updates #173

Merged

Conversation

cweedall
Copy link
Contributor

@cweedall cweedall commented Apr 14, 2024

With the update for JUnit, there were some breaking changes "Assert" vs. "Assertions", for example. These changes were done to reflect the dependency upgrades. There were no "assertTrue" methods anymore, so these were updated to failures in most cases. I included the exceptions in the fail() calls, but we could also simply use the original message, if desired.

Also organized the imports in a few places and removed unused ones.

I originally updated the Java version to 17 which is the most recent LTS. However, I opted to keep it at Java 8 for now because I did not know if there was a reason to keep it at that version. If there is no reason not to move to 17, then I can update the README to point to where to download Java 17 (probably Adoptium's releases who have JDKs and "JREs" which are really stripped-down JDKs).

OpenAPI's generator appears to have a Java 11 requirement. It all builds locally fine so I only noticed after pushing to Github. I made updates to reflect the need for Java 11.

@cweedall
Copy link
Contributor Author

For some reason, there are unit test failures appearing in Github which do not appear locally for me. I will update these after reviewing, so that the builds can succeed.

@mosoriob mosoriob merged commit 306efa6 into KnowledgeCaptureAndDiscovery:master Apr 15, 2024
3 checks passed
@mosoriob
Copy link
Contributor

Thanks @cweedall for the pull request.

Update the java version is a good idea.

#174

@cweedall cweedall deleted the misc/update-dependencies branch April 15, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants