Bugfix KNOWAGE-8140 #878
Merged
Bugfix KNOWAGE-8140 #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed files (all)
davide-zerbetto
suggested changes
Aug 29, 2023
knowage-core/src/main/java/it/eng/spagobi/commons/services/KnowageCaptchaServlet.java
Outdated
Show resolved
Hide resolved
knowage-core/src/main/java/it/eng/spagobi/commons/services/KnowageCaptchaServlet.java
kerny3d
reviewed
Oct 13, 2023
| public void init() throws ServletException { | ||
| super.init(); | ||
|
|
||
| private boolean getSerializedSession() { |
There was a problem hiding this comment.
It's ok but pay attention: the init() method is called only once; that means that in the past the value was read only one time at the boot of the application from a source which let you know the value of a changeable configuration. The code was in strong contradiction as you can say: i think nobody knows what is the right way to manage that value. Anyway this is the less worse way to manage this, good job.
kerny3d
reviewed
Oct 13, 2023
| @@ -107,7 +107,7 @@ | |||
| **/ | |||
| public class BirtReportServlet extends HttpServlet { | |||
|
|
|||
| private IReportEngine birtReportEngine = null; | |||
| // private IReportEngine birtReportEngine = null; | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed files (all)