Fix ordering and select-all button in map's filters functionality

KnowageLabs · Mar 9, 2020 · e945e68 · e945e68
1 parent cbdfe3f
commit e945e68
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/...webapp/js/src/angular_1.4/cockpit/directives/cockpit-widget/widget/mapWidget/mapWidget.js b/...webapp/js/src/angular_1.4/cockpit/directives/cockpit-widget/widget/mapWidget/mapWidget.js
@@ -1291,7 +1291,9 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 					// If sizes match, all items are already selected
 					var allAvailablesValuesSize = allAvailablesValues.length;
-					var selectablesSize = scope.selectables.length;
+					var selectablesSize = scope.selectables
+						.filter(function(elem) { return elem.selected; })
+						.length;
 
 					scope.allSelected = allAvailablesValuesSize == selectablesSize;
 

diff --git a/...kpit-widget/widget/mapWidget/templates/mapWidgetMultiSelectFilterValueDialogTemplate.html b/...kpit-widget/widget/mapWidget/templates/mapWidgetMultiSelectFilterValueDialogTemplate.html
@@ -24,7 +24,7 @@ <h2 class="text-transform-none">{{title}}</h2>
 		</div>
 		<md-list>
 			<md-virtual-repeat-container id="vertical-container">
-				<md-list-item class="selectableList" md-virtual-repeat="item in (availableItems = (selectables | filter:searchText)) | orderBy : 'item.value'">
+				<md-list-item class="selectableList" md-virtual-repeat="item in (availableItems = (selectables | filter:searchText)) | orderBy : 'value'">
 					<p class="truncated"> {{ item.value }} </p>
 					<md-checkbox class="md-secondary" ng-model="item.selected"></md-checkbox>
 				</md-list-item>