Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation of automated reports from those created by users #509

Merged
merged 2 commits into from
Apr 25, 2021
Merged

Separation of automated reports from those created by users #509

merged 2 commits into from
Apr 25, 2021

Conversation

rodkiewicz
Copy link
Contributor

@rodkiewicz rodkiewicz commented Mar 19, 2021

@rodkiewicz rodkiewicz changed the title Dodanie opcji filtrowania raportów po tym czy są stworzone przez bota czy nie. Oddzielenie zgłoszeń automatycznych od tworzonych przez użytkowników Mar 27, 2021
@rodkiewicz rodkiewicz changed the title Oddzielenie zgłoszeń automatycznych od tworzonych przez użytkowników Separation of automated reports from those created by users Mar 28, 2021
@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #509 (11f6c8c) into master (46b59bd) will decrease coverage by 0.06%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
- Coverage   83.96%   83.89%   -0.07%     
==========================================
  Files         105      105              
  Lines        3454     3465      +11     
  Branches      227      228       +1     
==========================================
+ Hits         2900     2907       +7     
- Misses        500      504       +4     
  Partials       54       54              
Impacted Files Coverage Δ
report/filters.py 75.75% <50.00%> (-5.73%) ⬇️
pola/management/commands/populate_db.py 80.55% <100.00%> (+3.13%) ⬆️
report/models.py 82.14% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c94db8...11f6c8c. Read the comment docs.

@mik-laj
Copy link
Member

mik-laj commented Apr 25, 2021

Tutaj można by dodać jakieś testy, aby mieć lepsze pokrycie, ale możemy to zrobić, jako osobny PR.

@mik-laj mik-laj merged commit 06f927c into KlubJagiellonski:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants