Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix annotation type associated with _toolbars variable #76

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

jcfr
Copy link
Collaborator

@jcfr jcfr commented Aug 22, 2024

Follow-up of 91c17c7 ("ENH: Refactor HomeWidget to support custom toolbars", 2024-08-21) updating the annotation to use the mutable type dict usable as annotation type in Python >= 3.9.

Follow-up of 91c17c7 ("ENH: Refactor HomeWidget to support custom toolbars", 2024-08-21)
updating the annotation to use the mutable type `dict` usable as annotation
type in Python >= 3.9.

Co-authored-by: Shreeraj Jadhav <[email protected]>
@jcfr jcfr requested a review from jadh4v August 22, 2024 16:32
Copy link
Member

@jadh4v jadh4v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks.

@jcfr jcfr merged commit 53b3d00 into KitwareMedical:main Aug 22, 2024
3 checks passed
@jcfr jcfr deleted the home-toolbars-fix-annotation branch August 22, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants