ENH: Refactor HomeWidget to support custom toolbars #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
force-pushed
the
refactor-toolbar-customization
branch
4 times, most recently
from
46fff79
to
ec771ad
Compare
This comment was marked as outdated.
This comment was marked as outdated.
sjh26
reviewed
Aug 21, 2024
jcfr
force-pushed
the
refactor-toolbar-customization
branch
2 times, most recently
from
0e03480
to
c58f1ba
Compare
Improves the `HomeWidget` class by introducing convenient functions
to managing custom toolbars in the application:
- Adds `toolbarNames` property to dynamically manage toolbar names
- Refactors the `modifyWindowUI` method to create and manage multiple
custom toolbars, introducing the following functions:
- `insertToolBar`: Helper method to insert a new custom toolbar
between existing ones.
- `initializeSettingsToolBar`: Creates the settings toolbar with the gear icon button to toggle
visibility of the settings dialog.
Co-authored-by: Tom Birdsong <[email protected]>
jcfr
force-pushed
the
refactor-toolbar-customization
branch
from
c58f1ba
to
43dc85d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the
HomeWidgetclass by introducing convenient functions to managing custom toolbars in the application:toolbarNamesproperty to dynamically manage toolbar namesmodifyWindowUImethod to create and manage multiple custom toolbars, introducing the following functions:insertToolBar: Helper method to insert a new custom toolbar between existing ones.initializeSettingsToolBar: Creates the settings toolbar with the gear icon button to toggle visibility of the settings dialog.