Add linux build instructions #60
Open
+50
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebrahimebrahim
force-pushed
the
add_linux_build_instructions
branch
from
6bcbfc4
to
951da5d
Compare
jcfr
reviewed
Jun 20, 2024
Leengit
reviewed
Jun 20, 2024
| -S {{cookiecutter.github_project}} \ | ||
| -B {{cookiecutter.github_project}}-SuperBuild-Release | ||
|
|
||
| make -j<N> |
There was a problem hiding this comment.
It could be best as is, though my usual approach is instead
cmake --build . -j<N>(Actually, I usually also throw in a --config Release for good measure, but I have no idea whether that is useful.)
|
|
||
| ## Package | ||
|
|
||
| From the inner build folder: | ||
| From the _inner build_ folder: | ||
|
|
||
| ```sh | ||
| make package |
There was a problem hiding this comment.
Likwwise, it could be best as is, though my usual approach is instead from the superbuild folder
cmake --build . --target package -j<N>(Also usually including --config Release.)
There was a problem hiding this comment.
Sorry, I'm wrong. I do that from the inner build folder.
There was a problem hiding this comment.
I guess the advantage is that it's a more platform-independent command.
I like that aspect of it, but I also prefer a simple and easy to remember command.
ebrahimebrahim
commented
Jun 20, 2024
ebrahimebrahim
force-pushed
the
add_linux_build_instructions
branch
2 times, most recently
from
a0fbf42
to
46927a4
Compare
This makes room for linux build instructions to be added
This doesn't make sense for a number of reasons: - Not every organization has a domain name like that or does emails like that with first and last names. - Email is not always the preferred mode of contact. - If someone can read this BUILD_WINDOWS.md document, then they already have read access to the repo and do not need to request further access. Write access is not needed for cloning and building.
Build time depends on many factors and evolves as Slicer does
Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]>
It's only needed on ubuntu 20.04 pretty much so it should not be there in the main instruction.
ebrahimebrahim
force-pushed
the
add_linux_build_instructions
branch
from
46927a4
to
3371856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #56