Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Expose the CMake option for building the examples. #22

Merged
merged 1 commit into from
Jan 3, 2019
Merged

ENH: Expose the CMake option for building the examples. #22

merged 1 commit into from
Jan 3, 2019

Conversation

jhlegarreta
Copy link

Expose the CMake option for building the examples.

@jhlegarreta
ENH: Expose the CMake option for building the examples.
00107bb 
Expose the CMake option for building the examples.
@jhlegarreta
Copy link
Author

@thewtex @dzenanz @fbudin69500 Please review.

@jhlegarreta
Copy link
Author

jhlegarreta commented Dec 24, 2018 •
edited
Loading

Thanks @dzenanz !

I'll wait to the consensus on ITKModuleTemplate PR 46 before merging to avoid any overhead if the examples are to be added somehow in a different way. Same for the rest of remotes for which I added the option.

@jhlegarreta
Copy link
Author

jhlegarreta commented Jan 3, 2019 •
edited
Loading

Given that the addition was merged in the rest of remotes, and the discussion in ITKModuleTemplate seems to be one that will last for some time, please go ahead and merge @dzenanz. I do not have merge rights on this repository.

@dzenanz dzenanz merged commit d2a054c into KitwareMedical:master Jan 3, 2019
@jhlegarreta jhlegarreta deleted the EnableExamplesModule branch January 3, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhlegarreta @dzenanz