fix(serializer): register vtkCompositePolyDataMapper #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That won't work. vtk.js does not have such mapper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing registration causes examples of pyvista that utilize multiblock to fail.
These are currently broken see:
htmlas jupyter backend pyvista/pyvista#5437The suggested change fixes the issue. See the last two examples in https://pyvist-multiblock-examples-issues.netlify.app/some_plots.
The problem was found by exporting
export TRAME_SERIALIZE_DEBUG=1and compiling via sphinx the above example.