This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
Collection geojson properties on click #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbeezley Can you review this whenever you have time? I think it is almost ready. When clicked on boundaries it is not inspecting (for geojson only). Other than that everything works as expected. |
|
My last commit should fix the boundary issue. Everything else LGTM. |
|
Yes, it is fixed now. Thanks !!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dorukozturk This is about half the work required to get geojson property information to display on click. There are two blocks of code here:
pointSearchmethod on all features created for the dataset. Because all of data is assumed to be geojson, getting the properties is straightforward. After the underscore pipeline, I just print out the property array to the console.What I'm leaving for you is merging these property objects with those returned from the REST API for WMS layers further down in the function. Let me know if you have any questions.