Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to the head and neck example #63

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Minor improvements to the head and neck example #63

merged 1 commit into from
Oct 30, 2023

Conversation

sankhesh
Copy link
Contributor

  • Ability to switch between lung(L key) and bone (B key) transfer functions
  • Performance tweaks during interaction

@sankhesh
Minor improvements to the head and neck example
ee49877 
- Ability to switch between lung(L key) and bone (B key) transfer functions
- Performance tweaks during interaction
psavery
psavery approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@psavery psavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Examples/Python/cinematic_rendering/head_and_neck_front.py Show resolved Hide resolved
Examples/Python/cinematic_rendering/head_and_neck_front.py Show resolved Hide resolved
@psavery
Copy link
Collaborator

psavery commented Oct 30, 2023

The CI is only failing because cibuildwheel is trying to build wheels for python3.12, and the current version of VTK we depend on does not have wheels yet for python3.12. We can merge anyways and fix that issue in a separate PR.

@psavery psavery merged commit f77b1d1 into Kitware:master Oct 30, 2023
1 of 4 checks passed
@sankhesh sankhesh deleted the perf_updates branch October 31, 2023 02:31
@sankhesh
Copy link
Contributor Author

Thank you @psavery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psavery psavery psavery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sankhesh @psavery